Bug 72471

Summary: [chromium] Improvements for page scale delta during commit
Product: WebKit Reporter: Alexandre Elias <aelias>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aelias, cc-bugs, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alexandre Elias
Reported 2011-11-15 23:30:23 PST
[chromium] Improvements for page scale delta during commit
Attachments
Patch (13.31 KB, patch)
2011-11-15 23:43 PST, Alexandre Elias 		no flags
DetailsFormatted DiffDiff
Patch (21.47 KB, patch)
2011-11-16 12:51 PST, Alexandre Elias 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexandre Elias
Comment 1 2011-11-15 23:43:57 PST
Created attachment 115334 [details] Patch
James Robinson
Comment 2 2011-11-16 00:52:34 PST
Comment on attachment 115334 [details] Patch terminology request: we have pageScale and pageScaleDelta in most places but also scaleDelta and sentScaleDelta. Can the latter two please be pageScaleDelta and sentPageScaleDelta?
Alexandre Elias
Comment 3 2011-11-16 12:51:25 PST
Created attachment 115426 [details] Patch
Alexandre Elias
Comment 4 2011-11-16 12:53:18 PST
OK, renamed to pageScaleDelta everywhere.
James Robinson
Comment 5 2011-11-16 13:40:59 PST
Comment on attachment 115426 [details] Patch Looks great, thanks!
WebKit Review Bot
Comment 6 2011-11-16 14:38:10 PST
Comment on attachment 115426 [details] Patch Clearing flags on attachment: 115426 Committed r100508: <http://trac.webkit.org/changeset/100508>
WebKit Review Bot
Comment 7 2011-11-16 14:38:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.