| Summary: | [GTK] Add webkit_web_view_load_request() to WebKit2 GTK+ API | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | pnormand, svillar, webkit.review.bot | ||||
| Priority: | P2 | Keywords: | Gtk | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Attachments: |
|
||||||
|
Description
Carlos Garcia Campos
2011-11-15 04:54:21 PST
Created attachment 115146 [details]
Patch
Attachment 115146 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitNetworkRequest.h"
Source/WebKit2/UIProcess/API/gtk/WebKitNetworkRequest.cpp:92: Use 0 instead of NULL. [readability/null] [5]
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/webkit2.h"
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 115146 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115146&action=review >> Source/WebKit2/UIProcess/API/gtk/WebKitNetworkRequest.cpp:92 >> + NULL, > > Use 0 instead of NULL. [readability/null] [5] Please fix. Committed r100414: <http://trac.webkit.org/changeset/100414> |