Summary: | VCSUtils.pm doesn't handle svn 1.7 correctly | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Peter Kasting <pkasting> | ||||
Component: | Tools / Tests | Assignee: | Peter Kasting <pkasting> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aroben, hausmann, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Peter Kasting
2011-11-14 20:19:58 PST
Created attachment 115089 [details]
patch v1
This seems to work on my machine (tested both positively and negatively). Did not test on svn 1.6 or below.
Comment on attachment 115089 [details] patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=115089&action=review > Tools/Scripts/VCSUtils.pm:252 > + return system("cd $dir && svn info > " . File::Spec->devnull() . " 2>&1") == 0; I wonder if this will cause problems for folks using native Win32 Perl? Simon, any idea if this will be a problem for Qt/Win? (In reply to comment #3) > Simon, any idea if this will be a problem for Qt/Win? Don't think so :) Comment on attachment 115089 [details] patch v1 Clearing flags on attachment: 115089 Committed r100286: <http://trac.webkit.org/changeset/100286> All reviewed patches have been landed. Closing bug. |