Bug 72349

Summary: VCSUtils.pm doesn't handle svn 1.7 correctly
Product: WebKit Reporter: Peter Kasting <pkasting>
Component: Tools / TestsAssignee: Peter Kasting <pkasting>
Severity: Normal CC: aroben, hausmann, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
patch v1 none

Description Peter Kasting 2011-11-14 20:19:58 PST
$isSVNDirectory fails on svn 1.7 in non-root directories because svn 1.7 eliminates the .svn subdirectories everywhere but the root.

I'm going to fix this by blindly copying the git code, which instead shells out to git to do the work, and adapt it to use "svn info".
Comment 1 Peter Kasting 2011-11-14 20:22:21 PST
Created attachment 115089 [details]
patch v1

This seems to work on my machine (tested both positively and negatively).  Did not test on svn 1.6 or below.
Comment 2 Adam Roben (:aroben) 2011-11-15 06:33:14 PST
Comment on attachment 115089 [details]
patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=115089&action=review

> Tools/Scripts/VCSUtils.pm:252
> +    return system("cd $dir && svn info > " . File::Spec->devnull() . " 2>&1") == 0;

I wonder if this will cause problems for folks using native Win32 Perl?
Comment 3 Adam Roben (:aroben) 2011-11-15 06:33:43 PST
Simon, any idea if this will be a problem for Qt/Win?
Comment 4 Simon Hausmann 2011-11-15 07:12:24 PST
(In reply to comment #3)
> Simon, any idea if this will be a problem for Qt/Win?

Don't think so :)
Comment 5 WebKit Review Bot 2011-11-15 08:38:13 PST
Comment on attachment 115089 [details]
patch v1

Clearing flags on attachment: 115089

Committed r100286: <http://trac.webkit.org/changeset/100286>
Comment 6 WebKit Review Bot 2011-11-15 08:38:19 PST
All reviewed patches have been landed.  Closing bug.