Bug 72324

Summary: DFG put_by_id transition optimizations test the wrong structures
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch barraclough: review+

Filip Pizlo
Reported 2011-11-14 16:03:55 PST
Patch forthcoming
Attachments
the patch (4.09 KB, patch)
2011-11-14 16:08 PST, Filip Pizlo 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2011-11-14 16:08:39 PST
Created attachment 115053 [details] the patch
Gavin Barraclough
Comment 2 2011-11-14 16:36:27 PST
Comment on attachment 115053 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=115053&action=review > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1825 > + if (previousStructure->storedPrototype().isCell()) I would prefer if the 'isCell' check check was a !isNull() check for consistency.
Filip Pizlo
Comment 3 2011-11-14 17:04:29 PST
Landed in http://trac.webkit.org/changeset/100219
Filip Pizlo
Comment 4 2011-11-14 17:06:18 PST
<rdar://problem/10445229>
Note You need to log in before you can comment on or make changes to this bug.