Bug 72315

Summary: Mouse Lock: Renaming to 'Pointer Lock': MouseLockable to PointerLock
Product: WebKit Reporter: Vincent Scheib <scheib>
Component: New BugsAssignee: Vincent Scheib <scheib>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, gustavo, ojan, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

Vincent Scheib
Reported 2011-11-14 14:59:08 PST
Mouse Lock: Renaming to 'Pointer Lock': MouseLockable to PointerLock
Attachments
Patch (17.92 KB, patch)
2011-11-14 14:59 PST, Vincent Scheib 		no flags
DetailsFormatted DiffDiff
Patch (18.01 KB, patch)
2011-11-14 15:08 PST, Vincent Scheib 		no flags
DetailsFormatted DiffDiff
Patch (18.01 KB, patch)
2011-11-14 16:30 PST, Vincent Scheib 		no flags
DetailsFormatted DiffDiff
Patch (17.92 KB, patch)
2011-11-15 11:10 PST, Vincent Scheib 		no flags
DetailsFormatted DiffDiff
Patch for landing (17.92 KB, patch)
2011-11-15 13:28 PST, Vincent Scheib 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Vincent Scheib
Comment 1 2011-11-14 14:59:45 PST
Created attachment 115036 [details] Patch
Vincent Scheib
Comment 2 2011-11-14 15:06:09 PST
Comment on attachment 115036 [details] Patch -- oops, forgot to edit the [Conditional...] new patch coming shortly...
Vincent Scheib
Comment 3 2011-11-14 15:08:24 PST
Created attachment 115038 [details] Patch
Dimitri Glazkov (Google)
Comment 4 2011-11-14 15:23:46 PST
Comment on attachment 115038 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115038&action=review > Source/WebCore/page/Navigator.idl:47 > + readonly attribute [Conditional=POINTER_LOCK,EnabledAtRuntime] PointerLock webkitPointer; space after comma?
Gustavo Noronha (kov)
Comment 5 2011-11-14 15:36:51 PST
Comment on attachment 115038 [details] Patch Attachment 115038 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10483071
Vincent Scheib
Comment 6 2011-11-14 16:29:33 PST
Addressing Dimitri's space nit. Also, rekicking gtk EWS, seems to be an unrelated error?
Vincent Scheib
Comment 7 2011-11-14 16:30:11 PST
Created attachment 115054 [details] Patch
Gustavo Noronha (kov)
Comment 8 2011-11-14 17:35:35 PST
Comment on attachment 115054 [details] Patch Attachment 115054 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10484117
Vincent Scheib
Comment 9 2011-11-15 11:10:18 PST
Created attachment 115205 [details] Patch
Vincent Scheib
Comment 10 2011-11-15 11:12:00 PST
GTK was still failing? Not certain what the issue is. Attempting with Navigator.idl no using [Conditional] on the attribute?
Vincent Scheib
Comment 11 2011-11-15 11:35:54 PST
Comment on attachment 115205 [details] Patch GTK was failing. I changed Navigator.idl to not use the [Conditional] prefix on the attribute, instead wrapping with "#if defined(ENABLE_POINTER_LOCK) ..." and the bot passes OK.
Vincent Scheib
Comment 12 2011-11-15 13:28:29 PST
Created attachment 115229 [details] Patch for landing
WebKit Review Bot
Comment 13 2011-11-15 14:39:10 PST
Comment on attachment 115229 [details] Patch for landing Clearing flags on attachment: 115229 Committed r100328: <http://trac.webkit.org/changeset/100328>
WebKit Review Bot
Comment 14 2011-11-15 14:39:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.