Bug 72293

Summary: [Chromium] build-webkit silently drops the features flags
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Tools / TestsAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: abarth, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: All   
Attachments:
Description Flags
Proposed fix: add a warning none

Julien Chaffraix
Reported 2011-11-14 11:29:58 PST
Currently build-webkit on Chromium does nothing with the @features variable but does not notify anyone! For the casual developer, it looks like everything is working, until the feature is not compiled in. Per discussion, fixing that is difficult without slowing down everybody's workflow so let's add a warning about that. Patch forthcoming.
Attachments
Proposed fix: add a warning (1.90 KB, patch)
2011-11-14 11:34 PST, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2011-11-14 11:34:58 PST
Created attachment 114994 [details] Proposed fix: add a warning
Tony Chang
Comment 2 2011-11-14 11:40:21 PST
Comment on attachment 114994 [details] Proposed fix: add a warning Thanks!
Julien Chaffraix
Comment 3 2011-11-14 12:53:09 PST
Comment on attachment 114994 [details] Proposed fix: add a warning Thanks for writing the wiki Tony!
WebKit Review Bot
Comment 4 2011-11-14 13:46:09 PST
Comment on attachment 114994 [details] Proposed fix: add a warning Clearing flags on attachment: 114994 Committed r100184: <http://trac.webkit.org/changeset/100184>
WebKit Review Bot
Comment 5 2011-11-14 13:46:13 PST
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 6 2011-11-16 21:43:26 PST
I get this message every time I build. I don't think I have any non-default features. Any idea what's wrong?
Tony Chang
Comment 7 2011-11-17 09:46:30 PST
(In reply to comment #6) > I get this message every time I build. I don't think I have any non-default features. Any idea what's wrong? I saw it on the bots too. I think it might be confused by --chromium? I'll take a look.
Julien Chaffraix
Comment 8 2011-11-17 09:54:34 PST
(In reply to comment #7) > (In reply to comment #6) > > I get this message every time I build. I don't think I have any non-default features. Any idea what's wrong? > > I saw it on the bots too. I think it might be confused by --chromium? I'll take a look. I don't think it is the --chromium as this should be the trigger for the behavior. I have seen the error for --debug but not for --release (or the other way around I can't recall) so I would look into those 2 first. I could investigate if you prefer!
Tony Chang
Comment 9 2011-11-17 09:59:03 PST
https://bugs.webkit.org/show_bug.cgi?id=72629
Adam Barth
Comment 10 2011-11-17 10:31:50 PST
*** This bug has been marked as a duplicate of bug 72629 ***
Note You need to log in before you can comment on or make changes to this bug.