Summary: | Web Inspector: Command line $x fails for 3 of 4 types of XPath query | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Pavel Feldman
2011-11-14 08:31:10 PST
Created attachment 114973 [details]
Patch
Comment on attachment 114973 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114973&action=review r+ is you land it with the style fixed. > Source/WebCore/inspector/InjectedScriptSource.js:600 > + case XPathResult.NUMBER_TYPE: return result.numberValue; > + case XPathResult.STRING_TYPE: return result.stringValue; > + case XPathResult.BOOLEAN_TYPE: return result.booleanValue; The case and the return should be on seperate lines. (In reply to comment #2) > (From update of attachment 114973 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=114973&action=review > > r+ is you land it with the style fixed. > > > Source/WebCore/inspector/InjectedScriptSource.js:600 > > + case XPathResult.NUMBER_TYPE: return result.numberValue; > > + case XPathResult.STRING_TYPE: return result.stringValue; > > + case XPathResult.BOOLEAN_TYPE: return result.booleanValue; > > The case and the return should be on seperate lines. Welcome back :) Committed r100246: <http://trac.webkit.org/changeset/100246> |