Bug 72276

Summary: Web Inspector: Command line $x fails for 3 of 4 types of XPath query
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch timothy: review+, timothy: commit-queue-

Description Pavel Feldman 2011-11-14 08:31:10 PST
(Upstream from http://code.google.com/p/chromium/issues/detail?id=97528).

Although we don't have to do that by the spec, it is a handy improvement.
Comment 1 Pavel Feldman 2011-11-14 10:03:05 PST
Created attachment 114973 [details]
Patch
Comment 2 Timothy Hatcher 2011-11-14 13:45:02 PST
Comment on attachment 114973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114973&action=review

r+ is you land it with the style fixed.

> Source/WebCore/inspector/InjectedScriptSource.js:600
> +        case XPathResult.NUMBER_TYPE: return result.numberValue;
> +        case XPathResult.STRING_TYPE: return result.stringValue;
> +        case XPathResult.BOOLEAN_TYPE: return result.booleanValue;

The case and the return should be on seperate lines.
Comment 3 Pavel Feldman 2011-11-14 23:50:29 PST
(In reply to comment #2)
> (From update of attachment 114973 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=114973&action=review
> 
> r+ is you land it with the style fixed.
> 
> > Source/WebCore/inspector/InjectedScriptSource.js:600
> > +        case XPathResult.NUMBER_TYPE: return result.numberValue;
> > +        case XPathResult.STRING_TYPE: return result.stringValue;
> > +        case XPathResult.BOOLEAN_TYPE: return result.booleanValue;
> 
> The case and the return should be on seperate lines.

Welcome back :)
Comment 4 Pavel Feldman 2011-11-15 00:09:16 PST
Committed r100246: <http://trac.webkit.org/changeset/100246>