Bug 72276 – Web Inspector: Command line $x fails for 3 of 4 types of XPath query

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Pavel Feldman]

(Upstream from http://code.google.com/p/chromium/issues/detail?id=97528).

Although we don't have to do that by the spec, it is a handy improvement.

[Pavel Feldman]

Created attachment 114973 [details]
Patch

[Timothy Hatcher]

Comment on attachment 114973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114973&action=review

r+ is you land it with the style fixed.

> Source/WebCore/inspector/InjectedScriptSource.js:600
> +        case XPathResult.NUMBER_TYPE: return result.numberValue;
> +        case XPathResult.STRING_TYPE: return result.stringValue;
> +        case XPathResult.BOOLEAN_TYPE: return result.booleanValue;

The case and the return should be on seperate lines.

[Pavel Feldman]

(In reply to comment #2)
> (From update of attachment 114973 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=114973&action=review
> 
> r+ is you land it with the style fixed.
> 
> > Source/WebCore/inspector/InjectedScriptSource.js:600
> > +        case XPathResult.NUMBER_TYPE: return result.numberValue;
> > +        case XPathResult.STRING_TYPE: return result.stringValue;
> > +        case XPathResult.BOOLEAN_TYPE: return result.booleanValue;
> 
> The case and the return should be on seperate lines.

Welcome back :)

[Pavel Feldman]

Committed r100246: <http://trac.webkit.org/changeset/100246>