Bug 72268

Summary:

Web Inspector: expose iframe window to the onShown event handler of panels & sidebars

Product:

WebKit

Reporter:

Andrey Kosyakov <caseq>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Kosyakov <caseq>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	pfeldman: review+

Andrey Kosyakov

Reported 2011-11-14 06:30:04 PST

- replace IFrameView with ExtensionView - inherit both ExtensionPanel and ExtensionSidebarPane from ExtensionView in the API - move Panel.{onShow|onHide} to ExtensionView, effectively disabling show/hide notifications for non-extension panels and enabling it for sidebar panes - expose iframe's window object in the onShow event handler

Attachments
Patch (24.97 KB, patch) 2011-11-14 06:32 PST, Andrey Kosyakov	pfeldman: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andrey Kosyakov

Comment 1 2011-11-14 06:32:12 PST

Created attachment 114935 [details] Patch

Andrey Kosyakov

Comment 2 2011-11-14 08:30:00 PST

Committed r100145: <http://trac.webkit.org/changeset/100145>

Note You need to log in before you can comment on or make changes to this bug.