Bug 72265

Summary: Web Inspector: add 'Show function definition' context menu item for function values
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch pfeldman: review+

Yury Semikhatsky
Reported 2011-11-14 06:19:31 PST
Web Inspector: add 'Show function definition' context menu item for function values
Attachments
Patch (6.33 KB, patch)
2011-11-14 06:21 PST, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (6.47 KB, patch)
2011-11-14 06:24 PST, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (6.47 KB, patch)
2011-11-14 06:26 PST, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2011-11-14 06:21:35 PST
Created attachment 114931 [details] Patch
Yury Semikhatsky
Comment 2 2011-11-14 06:24:54 PST
Created attachment 114933 [details] Patch
Yury Semikhatsky
Comment 3 2011-11-14 06:26:11 PST
Created attachment 114934 [details] Patch
Pavel Feldman
Comment 4 2011-11-14 06:37:53 PST
Comment on attachment 114934 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114934&action=review > Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:265 > + WebInspector.showPanelForAnchorNavigation(WebInspector.panels.scripts); Call this from the one below. > Source/WebCore/inspector/front-end/inspector.js:840 > if (this.drawer) You don't need this.
Yury Semikhatsky
Comment 5 2011-11-14 06:44:16 PST
(In reply to comment #4) > (From update of attachment 114934 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=114934&action=review > > > Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:265 > > + WebInspector.showPanelForAnchorNavigation(WebInspector.panels.scripts); > > Call this from the one below. > Done. > > Source/WebCore/inspector/front-end/inspector.js:840 > > if (this.drawer) > > You don't need this. Done.
Yury Semikhatsky
Comment 6 2011-11-14 07:56:27 PST
Committed r100143: <http://trac.webkit.org/changeset/100143>
Note You need to log in before you can comment on or make changes to this bug.