Bug 72259

Summary: [Qt][WK2] Cleanup QML tests.
Product: WebKit Reporter: Alexis Menard (darktears) <menard>
Component: WebKit QtAssignee: Alexis Menard (darktears) <menard>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, kenneth, ossy, vestbo, webkit.review.bot, zoltan
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Alexis Menard (darktears)
Reported 2011-11-14 05:23:16 PST
[Qt][WK2] Cleanup QML tests.
Attachments
Patch (49.84 KB, patch)
2011-11-14 05:26 PST, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexis Menard (darktears)
Comment 1 2011-11-14 05:26:04 PST
Created attachment 114922 [details] Patch
Alexis Menard (darktears)
Comment 2 2011-11-14 05:27:16 PST
@Tor-Arne: This will not trigger a rebuild as QML tests are dynamically loaded. I guess it should work out of the box but let's see.
Tor Arne Vestbø
Comment 3 2011-11-14 05:45:07 PST
Should work yes. If not, there are qmake-tricks we can pull to make the test-target-executable depend on all the QML files as well, if that's needed for some reason.
Simon Hausmann
Comment 4 2011-11-14 07:51:17 PST
Comment on attachment 114922 [details] Patch rs=me
WebKit Review Bot
Comment 5 2011-11-14 09:16:43 PST
Comment on attachment 114922 [details] Patch Clearing flags on attachment: 114922 Committed r100155: <http://trac.webkit.org/changeset/100155>
WebKit Review Bot
Comment 6 2011-11-14 09:16:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.