Bug 72247

Summary: Add SCMDetector object to make scm detection mockable
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ojan, pnormand, tonyg, vanuan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 76630    
Bug Blocks:    
Attachments:
Description Flags
Patch abarth: review+

Eric Seidel (no email)
Reported 2011-11-13 23:59:29 PST
Add SCMDetector object to make scm detection mockable
Attachments
Patch (23.18 KB, patch)
2011-11-14 00:02 PST, Eric Seidel (no email) 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-11-14 00:02:02 PST
Created attachment 114893 [details] Patch
Eric Seidel (no email)
Comment 2 2011-11-14 00:08:05 PST
Committed r100104: <http://trac.webkit.org/changeset/100104>
Daniel Bates
Comment 3 2011-11-14 00:29:40 PST
Comment on attachment 114893 [details] Patch Clearing the commit-queue flag since the patch for this bug was landed as per comment 2.
Tony Gentilcore
Comment 4 2011-11-14 02:46:36 PST
This patch appears to have broken windows builds. Rolling back shortly. Example log: https://bugs.webkit.org/show_bug.cgi?id=72247 Philn informs me I'll also need to roll back r100116, so I assume that should be part of the patch when it rolls forward again.
Tony Gentilcore
Comment 5 2011-11-14 02:48:48 PST
Reverted r100104 for reason: broke windows builds Committed r100118: <http://trac.webkit.org/changeset/100118>
Tony Gentilcore
Comment 6 2011-11-14 02:57:17 PST
> Example log: > https://bugs.webkit.org/show_bug.cgi?id=72247 Copy/paste fail. Log is: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Vista/builds/8621/steps/webkit_tests/logs/stdio This showed up on XP, Vista and Win 7.
Eric Seidel (no email)
Comment 7 2011-11-14 13:01:23 PST
Yeah, that's fallout from adding _initialize_scm() before _engage_awesome_windows_hacks are called. Very easy to fix. Will re-land shortly.
Eric Seidel (no email)
Comment 8 2011-11-16 00:46:51 PST
We're now engaging windows hacks harder: http://trac.webkit.org/changeset/100421 I'll roll this back in tomorrow when I'm more awake.
Eric Seidel (no email)
Comment 9 2011-11-16 21:09:07 PST
Committed r100558: <http://trac.webkit.org/changeset/100558>
vanuan
Comment 10 2011-11-18 08:40:45 PST
Seems like this patch has broken tests for me. 'svn info' is locale dependent, so it always returns "ScriptError: svn info did not contain a Repository UUID." Obvious fix would be running svn info in clean environment. I can prepare a patch for this.
Note You need to log in before you can comment on or make changes to this bug.