Bug 72235

Summary:

[SOUP][WK2] Add initial WebCookieManagerSoup.cpp for webkit2

Product:

WebKit

Reporter:

Jongseok Yang <js45.yang>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gustavo, gyuyoung.kim, ryuan.choi, t.morawski, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Linux

Attachments:

Description	Flags
patch for WebCookieManagerSoup.cpp	gustavo: review-, gustavo: commit-queue-
patch v2	none
patch v2 : re-upload	none
patch v3	none
Patch	none

Jongseok Yang

Reported 2011-11-13 20:43:50 PST

The implementation for WebCookieManager::platformSetHTTPCookieAcceptPolicy and WebCookieManager::platformGetHTTPCookieAcceptPolicy is required to support Webkit2 API for cookie manager. WebCookieManagerSoup.cpp includes these functions. If soup network back-end is used, the file should be used.

Attachments
patch for WebCookieManagerSoup.cpp (4.11 KB, patch) 2011-11-13 20:48 PST, Jongseok Yang	gustavo: review- gustavo: commit-queue-	Details Formatted Diff Diff
patch v2 (6.80 KB, patch) 2011-11-14 03:40 PST, Jongseok Yang	no flags	Details Formatted Diff Diff
patch v2 : re-upload (6.80 KB, patch) 2011-11-14 04:08 PST, Jongseok Yang	no flags	Details Formatted Diff Diff
patch v3 (8.81 KB, patch) 2011-11-14 23:39 PST, Jongseok Yang	no flags	Details Formatted Diff Diff
Patch (9.48 KB, patch) 2011-11-15 00:17 PST, Jongseok Yang	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Jongseok Yang

Comment 1 2011-11-13 20:48:54 PST

Created attachment 114873 [details] patch for WebCookieManagerSoup.cpp

Gustavo Noronha (kov)

Comment 2 2011-11-14 03:07:36 PST

Comment on attachment 114873 [details] patch for WebCookieManagerSoup.cpp This patch looks good to me, but it isn't wired into any of the build systems, that's why I r- it. You should wire it into the gtk (unconditionally) and efl (conditioned on it using soup) build systems at least, I believe.

Jongseok Yang

Comment 3 2011-11-14 03:40:39 PST

Created attachment 114912 [details] patch v2 The patch updates "Source/WebKit2/GNUmakefile.am" to build "WebCookieManagerSoup.cpp". And it removes "WebCookieManagerGtk.cpp" because gtk port uses soup network backend.

Jongseok Yang

Comment 4 2011-11-14 04:08:36 PST

Created attachment 114915 [details] patch v2 : re-upload

Gyuyoung Kim

Comment 5 2011-11-14 23:05:06 PST

(In reply to comment #2) > (From update of attachment 114873 [details]) > This patch looks good to me, but it isn't wired into any of the build systems, that's why I r- it. You should wire it into the gtk (unconditionally) and efl (conditioned on it using soup) build systems at least, I believe. AFAIK, efl port of WebKit2 will use soup or curl as well. So, I think WebCookieManagerEfl.cpp is able to be removed. How do you think remove WebCookieManagerEfl.cpp together?

Jongseok Yang

Comment 6 2011-11-14 23:24:36 PST

(In reply to comment #5) > (In reply to comment #2) > > (From update of attachment 114873 [details] [details]) > > This patch looks good to me, but it isn't wired into any of the build systems, that's why I r- it. You should wire it into the gtk (unconditionally) and efl (conditioned on it using soup) build systems at least, I believe. > > AFAIK, efl port of WebKit2 will use soup or curl as well. So, I think WebCookieManagerEfl.cpp is able to be removed. How do you think remove WebCookieManagerEfl.cpp together? I agree with you. I'll remove WebCookieManagerEfl.cpp. And the patch for CMakeListsEfl.txt should include the change of my patch.(https://bugs.webkit.org/show_bug.cgi?id=61999)

Tomasz Morawski

Comment 7 2011-11-14 23:32:59 PST

> And the patch for CMakeListsEfl.txt should include the change of my patch.(https://bugs.webkit.org/show_bug.cgi?id=61999) Not only changed by finally merged to avoid similar issues in future.

Jongseok Yang

Comment 8 2011-11-14 23:39:27 PST

Created attachment 115107 [details] patch v3 the patch removes WebCookieManagerGtk.cpp, WebCookieManagerEfl.cpp

Jongseok Yang

Comment 9 2011-11-15 00:17:58 PST

Created attachment 115111 [details] Patch

Gustavo Noronha (kov)

Comment 10 2011-11-15 08:17:52 PST

Comment on attachment 115111 [details] Patch OK!

WebKit Review Bot

Comment 11 2011-11-15 16:26:29 PST

Comment on attachment 115111 [details] Patch Clearing flags on attachment: 115111 Committed r100362: <http://trac.webkit.org/changeset/100362>

WebKit Review Bot

Comment 12 2011-11-15 16:26:34 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.