Bug 72205

Summary: Remove Duplicate Symbol Exports
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebCore Misc.Assignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, ddkilzer, joepeck
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix mitz: review+

Description Joseph Pecoraro 2011-11-11 20:49:49 PST
shell> find-duplicate-exports.rb Source/WebCore/WebCore.exp.in
Duplicate: __ZN7WebCore15setDOMExceptionEPN3JSC9ExecStateEi on line 1579, original was on line 472
Duplicate: __ZN7WebCore9HTMLNames8videoTagE on line 1909, original was on line 1068
Duplicate: __ZN7WebCore8Document12updateLayoutEv on line 1922, original was on line 898
Duplicate: __ZNK7WebCore13ResourceErrorcvP7NSErrorEv on line 1977, original was on line 1201

Each of these duplicate symbols was mentioned in a #if section but was already always defined anyways.
JavaScriptCore and WebKit exp files had no duplicates (according to my script).
Comment 1 Joseph Pecoraro 2011-11-11 20:51:41 PST
Created attachment 114817 [details]
[PATCH] Proposed Fix
Comment 2 Alexey Proskuryakov 2013-03-16 22:40:45 PDT
These symbols are not duplicate now, this must have been landed.