Bug 72205 - Remove Duplicate Symbol Exports
Summary: Remove Duplicate Symbol Exports
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-11 20:49 PST by Joseph Pecoraro
Modified: 2013-03-16 22:40 PDT (History)
3 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.18 KB, patch)
2011-11-11 20:51 PST, Joseph Pecoraro 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2011-11-11 20:49:49 PST 
shell> find-duplicate-exports.rb Source/WebCore/WebCore.exp.in
Duplicate: __ZN7WebCore15setDOMExceptionEPN3JSC9ExecStateEi on line 1579, original was on line 472
Duplicate: __ZN7WebCore9HTMLNames8videoTagE on line 1909, original was on line 1068
Duplicate: __ZN7WebCore8Document12updateLayoutEv on line 1922, original was on line 898
Duplicate: __ZNK7WebCore13ResourceErrorcvP7NSErrorEv on line 1977, original was on line 1201

Each of these duplicate symbols was mentioned in a #if section but was already always defined anyways.
JavaScriptCore and WebKit exp files had no duplicates (according to my script).
Comment 1 Joseph Pecoraro 2011-11-11 20:51:41 PST 
Created attachment 114817 [details]
[PATCH] Proposed Fix
Comment 2 Alexey Proskuryakov 2013-03-16 22:40:45 PDT 
These symbols are not duplicate now, this must have been landed.