Bug 72196

Summary: Remove the CSS3_FLEXBOX compile time flag and enable on all ports
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt, macpherson, peter, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 62048    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Description Tony Chang 2011-11-11 16:35:21 PST 
Remove the CSS3_FLEXBOX compile time flag and enable on all ports
Comment 1 Tony Chang 2011-11-11 16:42:53 PST 
Created attachment 114800 [details]
Patch
Comment 2 Tony Chang 2011-11-14 09:31:22 PST 
Created attachment 114965 [details]
Patch
Comment 3 Tony Chang 2011-11-14 10:57:51 PST 
Created attachment 114984 [details]
Patch
Comment 4 Ojan Vafai 2011-11-14 12:14:17 PST 
Comment on attachment 114984 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114984&action=review

> Source/WebCore/css/CSSValueKeywords.in:329
>  -webkit-box
>  -webkit-inline-box
> --wap-marquee
>  -webkit-flexbox
>  -webkit-inline-flexbox
> +-wap-marquee

I'm not convinced this is correct. I expect this is dead code, but this should be a separate patch.
Comment 5 Tony Chang 2011-11-14 13:58:26 PST 
Created attachment 115028 [details]
Patch for landing
Comment 6 WebKit Review Bot 2011-11-14 14:52:08 PST 
Comment on attachment 115028 [details]
Patch for landing

Clearing flags on attachment: 115028

Committed r100198: <http://trac.webkit.org/changeset/100198>
Comment 7 WebKit Review Bot 2011-11-14 14:52:13 PST 
All reviewed patches have been landed.  Closing bug.