Bug 72175 – Only define BUILDING_ON_* and TARGETING_* macros when building for Mac OS X

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

Created attachment 114763 [details]
Patch

<http://webkit.org/b/NNNNN>

Reviewed by NOBODY (OOPS!).

* wtf/Platform.h: Move the definition of the BUILDING_ON_* and
TARGETING_* macros to where the WTF_OS_MAC_OS_X macro is defined
so that they're only defined on Mac OS X builds.  Also include
Availability.h, which is needed on iOS builds.
---
 2 files changed, 25 insertions(+), 13 deletions(-)

[WebKit Review Bot]

Attachment 114763 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Joseph Pecoraro]

Comment on attachment 114763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114763&action=review

> Source/JavaScriptCore/wtf/Platform.h:327
> +    || (defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE)                   \

Might as well fix the end of line spacing on this line. Either have the "\"s line up
(like I think is normal for macros) or just one space after the line.

[David Kilzer (:ddkilzer)]

Committed r100031: <http://trac.webkit.org/changeset/100031>

[David Kilzer (:ddkilzer)]

<rdar://problem/7876444>