Bug 72150

Summary: Mouse Lock Navigator IDL
Product: WebKit Reporter: Vincent Scheib <scheib>
Component: New BugsAssignee: Vincent Scheib <scheib>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 72164    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Vincent Scheib
Reported 2011-11-11 10:39:37 PST
Mouse Lock Navigator IDL
Attachments
Patch (11.88 KB, patch)
2011-11-11 10:41 PST, Vincent Scheib 		no flags
DetailsFormatted DiffDiff
Patch (11.91 KB, patch)
2011-11-12 22:29 PST, Vincent Scheib 		no flags
DetailsFormatted DiffDiff
Patch (12.00 KB, patch)
2011-11-12 22:35 PST, Vincent Scheib 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Vincent Scheib
Comment 1 2011-11-11 10:41:45 PST
Created attachment 114729 [details] Patch
Vincent Scheib
Comment 2 2011-11-11 10:46:44 PST
Specification: http://dvcs.w3.org/hg/webevents/raw-file/default/mouse-lock.html
Vincent Scheib
Comment 3 2011-11-11 11:09:58 PST
Committed r99994: <http://trac.webkit.org/changeset/99994>
Vincent Scheib
Comment 4 2011-11-11 12:24:43 PST
Reverted r99994 for reason: Broke chromium windows build Committed r100004: <http://trac.webkit.org/changeset/100004>
Vincent Scheib
Comment 5 2011-11-12 22:29:07 PST
Created attachment 114853 [details] Patch
Vincent Scheib
Comment 6 2011-11-12 22:31:21 PST
Comment on attachment 114853 [details] Patch Windows build required an include for VoidCallback vs an empty declaration.
Vincent Scheib
Comment 7 2011-11-12 22:35:42 PST
Created attachment 114854 [details] Patch
Vincent Scheib
Comment 8 2011-11-13 07:26:18 PST
Committed r100091: <http://trac.webkit.org/changeset/100091>
Darin Fisher (:fishd, Google)
Comment 9 2011-11-14 23:09:05 PST
Comment on attachment 114854 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114854&action=review > Source/WebCore/page/MouseLockable.idl:31 > + void webkitLock(in Element target, in [Callback, Optional] VoidCallback successCallback, in [Callback, Optional] VoidCallback failureCallback); since MouseLockable is accessed via navigator.webkitPointer, it seems like you shouldn't need the webkit-prefix on any of these attributes. elsewhere, we only prefix the top-level attribute. see window.webkitNotifications for example.
Note You need to log in before you can comment on or make changes to this bug.