Bug 72148

Summary: [EFL] Add a few more web database functions to ewk_settings.
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: WebKit EFLAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, gyuyoung.kim, kenneth, leandro, lucas.de.marchi, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 72139    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Raphael Kubo da Costa (:rakuco)
Reported 2011-11-11 10:12:35 PST
[EFL] Add a few more web database functions to ewk_settings.
Attachments
Patch (5.54 KB, patch)
2011-11-11 10:14 PST, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2011-11-11 10:14:13 PST
Created attachment 114724 [details] Patch
Gyuyoung Kim
Comment 2 2011-11-11 10:17:40 PST
Comment on attachment 114724 [details] Patch Attachment 114724 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10460263
Raphael Kubo da Costa (:rakuco)
Comment 3 2011-11-11 10:26:05 PST
Comment on attachment 114724 [details] Patch Clearing r?, this one depends on bug 72139.
Raphael Kubo da Costa (:rakuco)
Comment 4 2011-11-16 10:41:34 PST
Comment on attachment 114724 [details] Patch The patch applies cleanly now. Flagging r? and cq? again.
Gyuyoung Kim
Comment 5 2011-12-07 18:07:37 PST
Comment on attachment 114724 [details] Patch LGTM.
Gyuyoung Kim
Comment 6 2011-12-07 18:29:33 PST
(In reply to comment #5) > (From update of attachment 114724 [details]) > LGTM. Hmm, though this patch doesn't make build break, efl EWS shows build error. I think you need to submit patch again to run this patch on efl EWS.
WebKit Review Bot
Comment 7 2011-12-15 11:11:52 PST
Comment on attachment 114724 [details] Patch Clearing flags on attachment: 114724 Committed r102966: <http://trac.webkit.org/changeset/102966>
WebKit Review Bot
Comment 8 2011-12-15 11:11:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.