Bug 72146

Summary: [chromium] Remove 2 static initializers and 3 exit time destructors. Turn on -Wexit-time-destructors.
Product: WebKit Reporter: Nico Weber <thakis>
Component: New BugsAssignee: Nico Weber <thakis>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Nico Weber
Reported 2011-11-11 10:00:12 PST
[chromium] Remove 2 static initializers and 3 exit time destructors. Turn on -Wexit-time-destructors.
Attachments
Patch (10.58 KB, patch)
2011-11-11 10:01 PST, Nico Weber 		no flags
DetailsFormatted DiffDiff
Patch (12.94 KB, patch)
2011-11-11 10:38 PST, Nico Weber 		no flags
DetailsFormatted DiffDiff
Patch (12.88 KB, patch)
2011-11-11 20:20 PST, Nico Weber 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nico Weber
Comment 1 2011-11-11 10:01:21 PST
Created attachment 114721 [details] Patch
Nico Weber
Comment 2 2011-11-11 10:28:23 PST
Comment on attachment 114721 [details] Patch Two more on linux/clang…
Nico Weber
Comment 3 2011-11-11 10:38:21 PST
Created attachment 114727 [details] Patch
WebKit Review Bot
Comment 4 2011-11-11 18:09:22 PST
Comment on attachment 114727 [details] Patch Rejecting attachment 114727 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: n/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/10350677
James Robinson
Comment 5 2011-11-11 18:11:32 PST
Comment on attachment 114727 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114727&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) can't commit with this puppy
Nico Weber
Comment 6 2011-11-11 20:20:49 PST
Created attachment 114816 [details] Patch
WebKit Review Bot
Comment 7 2011-11-11 21:24:24 PST
Comment on attachment 114816 [details] Patch Clearing flags on attachment: 114816 Committed r100070: <http://trac.webkit.org/changeset/100070>
WebKit Review Bot
Comment 8 2011-11-11 21:24:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.