Bug 72132

Summary: [EFL] Clean up the offline apps-related functions in ewk_settings.
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: WebKit EFLAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, leandro, lucas.de.marchi, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 72127    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Raphael Kubo da Costa (:rakuco)
Reported 2011-11-11 08:30:15 PST
[EFL] Clean up the offline apps-related functions in ewk_settings.
Attachments
Patch (10.92 KB, patch)
2011-11-11 08:33 PST, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2011-11-11 08:33:01 PST
Created attachment 114704 [details] Patch
WebKit Review Bot
Comment 2 2011-11-13 14:54:43 PST
Comment on attachment 114704 [details] Patch Rejecting attachment 114704 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: out of 2 hunks FAILED -- saving rejects to file Source/WebKit/efl/ewk/ewk_settings.cpp.rej patching file Source/WebKit/efl/ewk/ewk_settings.h patching file Source/WebKit/efl/ewk/ewk_view.cpp patching file Source/WebKit/efl/ewk/ewk_view.h patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christia..." exit_code: 1 Full output: http://queues.webkit.org/results/10473037
Raphael Kubo da Costa (:rakuco)
Comment 3 2011-11-16 07:16:08 PST
Comment on attachment 114704 [details] Patch Seems to be applying fine after some related patches got in. Flagging cq? again.
WebKit Review Bot
Comment 4 2011-11-16 07:58:57 PST
Comment on attachment 114704 [details] Patch Clearing flags on attachment: 114704 Committed r100452: <http://trac.webkit.org/changeset/100452>
WebKit Review Bot
Comment 5 2011-11-16 07:59:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.