Summary: | REGRESSION(r99964): Broke too many Qt tests (Requested by tronical_ on #webkit). | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | WebKit Review Bot <webkit.review.bot> | ||||
Component: | New Bugs | Assignee: | WebKit Review Bot <webkit.review.bot> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | hausmann, menard, ossy, pierre.rossi, vestbo | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 67773 | ||||||
Attachments: |
|
Description
WebKit Review Bot
2011-11-11 07:49:04 PST
Created attachment 114698 [details] ROLLOUT of r99964 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. Comment on attachment 114698 [details] ROLLOUT of r99964 Clearing flags on attachment: 114698 Committed r99968: <http://trac.webkit.org/changeset/99968> All reviewed patches have been landed. Closing bug. I don't know how, but it broke the build on the Qt SL bot on build.webkit.org: http://build.webkit.org/builders/Qt%20SnowLeopard%20Release/builds/4094/steps/compile-webkit/logs/stdio But the build works fine on the Qt SL bot on build.webkit.sed.hu. Maybe a build system bug caused it, I don't know. The rollout or the original patch? (In reply to comment #5) > The rollout or the original patch? The rollout broke the build: http://build.webkit.org/builders/Qt%20SnowLeopard%20Release/builds/4094 It's strange, it's in a totally unrelated file, qmake was run on the .pro file but somehow the generated makefile doesn't compile & link in the moc generated code. |