Bug 72114

Summary: [chromium] MediaStream API: Allow for null WebPeerConnectionHandler
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebKit APIAssignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, fishd, grunell, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Tommy Widenflycht
Reported 2011-11-11 04:59:30 PST
Fixing crash if WebKitPlatformSupport returns a null WebPeerConnectionHandler to PeerConnectionHandlerInternal.
Attachments
Patch (5.88 KB, patch)
2011-11-11 05:03 PST, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (5.96 KB, patch)
2011-11-14 03:01 PST, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2011-11-11 05:03:13 PST
Created attachment 114675 [details] Patch
WebKit Review Bot
Comment 2 2011-11-11 05:04:50 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Adam Barth
Comment 3 2011-11-13 22:13:55 PST
Comment on attachment 114675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114675&action=review > Source/WebKit/chromium/public/WebKitPlatformSupport.h:328 > + // May return null. It would be nice to explain the situations in which this function can return null.
Tommy Widenflycht
Comment 4 2011-11-14 03:01:27 PST
Created attachment 114908 [details] Patch
Tommy Widenflycht
Comment 5 2011-11-14 03:02:42 PST
Comment on attachment 114675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114675&action=review >> Source/WebKit/chromium/public/WebKitPlatformSupport.h:328 >> + // May return null. > > It would be nice to explain the situations in which this function can return null. Fixed.
Adam Barth
Comment 6 2011-11-14 08:42:01 PST
Comment on attachment 114908 [details] Patch Technically we need fishd to review, but given that you're just adding a comment to the API, I think it's fine.
WebKit Review Bot
Comment 7 2011-11-14 10:06:50 PST
Comment on attachment 114908 [details] Patch Clearing flags on attachment: 114908 Committed r100162: <http://trac.webkit.org/changeset/100162>
WebKit Review Bot
Comment 8 2011-11-14 10:06:56 PST
All reviewed patches have been landed. Closing bug.
Darin Fisher (:fishd, Google)
Comment 9 2011-11-14 11:13:45 PST
Comment on attachment 114908 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114908&action=review > Source/WebKit/chromium/public/WebKitPlatformSupport.h:328 > + // May return null if WebRTC functionality is not avaliable or out of resources. nit: "avaliable" -> available
Note You need to log in before you can comment on or make changes to this bug.