Bug 72105

Summary: Finish SVGLengthContext conversion in svg/
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, macpherson, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 71780    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Nikolas Zimmermann
Reported 2011-11-11 02:49:30 PST
Remove the operator SVGLengthContext() from SVGElement, and move the last call-sites to pass SVGLengthContext instead of const SVGElement*.
Attachments
Patch (36.04 KB, patch)
2011-11-11 08:23 PST, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2011-11-11 08:23:00 PST
Created attachment 114703 [details] Patch This finished the introduction of SVGLengthContext. Doesn't affect any tests yet.
Antti Koivisto
Comment 2 2011-11-12 02:36:03 PST
Comment on attachment 114703 [details] Patch r=me
Nikolas Zimmermann
Comment 3 2011-11-12 02:39:37 PST
Comment on attachment 114703 [details] Patch Clearing flags, landed in r100075.
Nikolas Zimmermann
Comment 4 2011-11-12 02:51:12 PST
The build is broken. My patch does touch CodeGeneratorObjC.pm, but it is NOT my patch fault. paroga said on IRC that his build failed as well, locally, before my patch, with a fresh checkout. Public API change. There are missing public properties and/or methods from the "DOMHTMLAreaElement" class. @property(copy) NSString *accessKey; Died at WebCore/bindings/scripts//CodeGeneratorObjC.pm line 323. Public API change. There are missing public properties and/or methods from the "DOMHTMLAnchorElement" class. @property(copy) NSString *accessKey; Died at WebCore/bindings/scripts//CodeGeneratorObjC.pm line 323. ....
Note You need to log in before you can comment on or make changes to this bug.