Summary: | ApplicationCache manifest should work with any MIME type | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||
Component: | Page Loading | Assignee: | Michael Nordman <michaeln> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | adauria, dev+webkit, dglazkov, japhet, jchaffraix, michaeln, paulirish, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2011-11-10 18:14:44 PST
*** Bug 72449 has been marked as a duplicate of this bug. *** Created attachment 115428 [details]
mime
Comment on attachment 115428 [details] mime Rejecting attachment 115428 [details] from commit-queue. New failing tests: http/tests/appcache/wrong-content-type.html Full output: http://queues.webkit.org/results/10499141 The irony is that a chromium cl to ignore the mime-type waiting for this webkit patch to land, and instead of just skipping the test for chromium i choose to update webcore's logic to match... and of course the commit bot rejects it. The joy of multi-sided patches :) Comment on attachment 115428 [details] mime Attachment 115428 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10505097 New failing tests: http/tests/appcache/wrong-content-type.html Created attachment 115468 [details]
mime
temporarily skip this test in chromium's expecations file
Comment on attachment 115468 [details]
mime
Setting r+ - commit queue won't land with only a cq+ unless you manually in reviewer name in ChangeLog.
Comment on attachment 115468 [details] mime Rejecting attachment 115468 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/10485928 Comment on attachment 115468 [details] mime Clearing flags on attachment: 115468 Committed r100541: <http://trac.webkit.org/changeset/100541> All reviewed patches have been landed. Closing bug. *** Bug 74629 has been marked as a duplicate of this bug. *** |