Summary: | [MutationObservers] V8 bindings don't properly wrap all calls into JS | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Klein <adamk> | ||||
Component: | DOM | Assignee: | Adam Klein <adamk> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, antonm, fishd, japhet, pfeldman, rafaelw, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 72181, 72422, 72645 | ||||||
Bug Blocks: | 68729 | ||||||
Attachments: |
|
Description
Adam Klein
2011-11-10 14:52:03 PST
Per :dslomov, m_recursion should live in V8BindingPerIsolateData. Created attachment 117062 [details]
Patch
Note that this patch has the effect that old callers of callFunctionWithoutFrame now also check the max recursion depth, and invoke didLeaveScriptContext. Existing callers of instrumentedCallFunction get both of these PLUS (at no added cost) the V8GCController::checkMemoryUsage(). Comment on attachment 117062 [details] Patch Clearing flags on attachment: 117062 Committed r101490: <http://trac.webkit.org/changeset/101490> All reviewed patches have been landed. Closing bug. |