Bug 72061

Summary: Add ARMv7 support to the DFG JIT
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix
none
Added missing bug link ggaren: review+

Gavin Barraclough
Reported 2011-11-10 14:36:33 PST
Remaining tasks mainly consist of bug fixes & calling convention issues.
Attachments
Fix (22.48 KB, patch)
2011-11-10 14:40 PST, Gavin Barraclough 		no flags
DetailsFormatted DiffDiff
Added missing bug link (22.54 KB, patch)
2011-11-10 14:42 PST, Gavin Barraclough 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2011-11-10 14:40:48 PST
Created attachment 114575 [details] Fix
Gavin Barraclough
Comment 2 2011-11-10 14:42:56 PST
Created attachment 114577 [details] Added missing bug link
WebKit Review Bot
Comment 3 2011-11-10 14:49:36 PST
Attachment 114577 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGOperations.cpp:70: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/dfg/DFGOperations.cpp:83: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/dfg/DFGOperations.cpp:96: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/dfg/DFGOperations.cpp:567: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/dfg/DFGOperations.cpp:578: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h:193: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 6 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 4 2011-11-10 14:55:35 PST
Comment on attachment 114577 [details] Added missing bug link r=me
Gavin Barraclough
Comment 5 2011-11-10 15:02:46 PST
Fixed in r99904
Note You need to log in before you can comment on or make changes to this bug.