Bug 72061 - Add ARMv7 support to the DFG JIT
Summary: Add ARMv7 support to the DFG JIT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-10 14:36 PST by Gavin Barraclough
Modified: 2011-11-10 15:02 PST (History)
1 user (show)

See Also:


Attachments
Fix (22.48 KB, patch)
2011-11-10 14:40 PST, Gavin Barraclough
no flags Details | Formatted Diff | Diff
Added missing bug link (22.54 KB, patch)
2011-11-10 14:42 PST, Gavin Barraclough
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2011-11-10 14:36:33 PST
Remaining tasks mainly consist of bug fixes & calling convention issues.
Comment 1 Gavin Barraclough 2011-11-10 14:40:48 PST
Created attachment 114575 [details]
Fix
Comment 2 Gavin Barraclough 2011-11-10 14:42:56 PST
Created attachment 114577 [details]
Added missing bug link
Comment 3 WebKit Review Bot 2011-11-10 14:49:36 PST
Attachment 114577 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/dfg/DFGOperations.cpp:70:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/dfg/DFGOperations.cpp:83:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/dfg/DFGOperations.cpp:96:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/dfg/DFGOperations.cpp:567:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/dfg/DFGOperations.cpp:578:  The parameter name """" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h:193:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 6 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Geoffrey Garen 2011-11-10 14:55:35 PST
Comment on attachment 114577 [details]
Added missing bug link

r=me
Comment 5 Gavin Barraclough 2011-11-10 15:02:46 PST
Fixed in r99904