Bug 72054
| Summary: | Could round rather than truncate in compileClampDoubleToByte? | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> |
| Component: | JavaScriptCore | Assignee: | Keith Miller <keith_miller> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | ahmad.saleem792, commit-queue, keith_miller, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 260534 | ||
| Bug Blocks: | |||
Gavin Barraclough
There is a +0.5 followed by truncate in the DFG JIT, may be able to replace this with a round.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
https://github.com/WebKit/WebKit/blob/main/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp#L3555
It is still present in the Source Code.
Keith Miller
This also has the wrong semantics. It should be a round to nearest not a round to infinity. Uploading a patch now.
Keith Miller
Pull request: https://github.com/WebKit/WebKit/pull/16609
EWS
Committed 267100@main (c55d0673236c): <https://commits.webkit.org/267100@main>
Reviewed commits have been landed. Closing PR #16609 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/114208146>
WebKit Commit Bot
Re-opened since this is blocked by bug 260534