Bug 72035

Summary: De-virtualize supportsProfiling, supportsRichSourceInfo, shouldInterruptScript in JSGlobalObject
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Mark Hahnenberg
Reported 2011-11-10 11:03:47 PST
We're trying to de-virtualize JSGlobalObject, so in order to do that we need to de-virtualize these three functions. One way to do that would be to provide a method table just for JSGlobalObject to prevent pollution of the primary MethodTable in ClassInfo just for the sake of JSGlobalObject (and JSDOMWindowBase).
Attachments
Patch (17.59 KB, patch)
2011-11-10 12:09 PST, Mark Hahnenberg 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2011-11-10 12:09:48 PST
Created attachment 114538 [details] Patch
Geoffrey Garen
Comment 2 2011-11-10 15:44:04 PST
Comment on attachment 114538 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114538&action=review r=me > Source/WebCore/bindings/js/JSDOMWindowBase.cpp:60 > + m_globalObjectMethodTable = &s_globalObjectMethodTable; Initialization syntax is better.
Mark Hahnenberg
Comment 3 2011-11-11 11:37:07 PST
Committed r99997: <http://trac.webkit.org/changeset/99997>
Note You need to log in before you can comment on or make changes to this bug.