Bug 72022

Summary: Web Inspector: [SuggestBox] Correctly position the box under the first character of the suggestion prefix.
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+

Alexander Pavlov (apavlov)
Reported 2011-11-10 06:27:31 PST
Patch to follow
Attachments
Patch (7.17 KB, patch)
2011-11-10 08:15 PST, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
Patch (10.32 KB, patch)
2011-11-10 08:59 PST, Alexander Pavlov (apavlov) 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 2011-11-10 08:15:39 PST
Created attachment 114506 [details] Patch
Pavel Feldman
Comment 2 2011-11-10 08:20:18 PST
Comment on attachment 114506 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114506&action=review > Source/WebCore/inspector/front-end/TextPrompt.js:869 > + * @param {*=} anchorBox This is not nice. > Source/WebCore/inspector/front-end/TextPrompt.js:884 > + anchorBox = this._anchorBox || this._inputElement.boxInWindow(window, this._parentElement); This is a strange control flow: if given, use, otherwise check if it has been used, otherwise do something.
Alexander Pavlov (apavlov)
Comment 3 2011-11-10 08:59:01 PST
Created attachment 114514 [details] Patch
Pavel Feldman
Comment 4 2011-11-10 09:02:55 PST
Comment on attachment 114514 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114514&action=review > Source/WebCore/inspector/front-end/TextPrompt.js:383 > + var anchorElement = textRange.startContainer.ownerDocument.createElement("span"); document.createElement
Alexander Pavlov (apavlov)
Comment 5 2011-11-10 09:07:19 PST
Committed r99867: <http://trac.webkit.org/changeset/99867>
Note You need to log in before you can comment on or make changes to this bug.