Bug 72007

Summary: A test for css parser number types problem.
Product: WebKit Reporter: Szilard Ledan <szledan>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit.review.bot, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 69083    
Attachments:
Description Flags
A test for CSS lexer rules, where the dimensions define like utf-8 code.
zherczeg: review-
Updated patch none

Szilard Ledan
Reported 2011-11-10 01:52:44 PST
The css number types (px, pt, cm, ...) can be specified escape sequences (px = \70\78,...).
Attachments
A test for CSS lexer rules, where the dimensions define like utf-8 code. (4.03 KB, patch)
2011-11-11 00:21 PST, Szilard Ledan 		zherczeg: review-
DetailsFormatted DiffDiff
Updated patch (5.12 KB, patch)
2011-11-22 05:12 PST, Szilard Ledan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Szilard Ledan
Comment 1 2011-11-11 00:21:52 PST
Created attachment 114637 [details] A test for CSS lexer rules, where the dimensions define like utf-8 code.
Zoltan Herczeg
Comment 2 2011-11-11 00:34:48 PST
Please set r? to the patch.
Szilard Ledan
Comment 3 2011-11-11 00:42:58 PST
(In reply to comment #2) > Please set r? to the patch. Thanks!
Zoltan Herczeg
Comment 4 2011-11-21 00:15:56 PST
Comment on attachment 114637 [details] A test for CSS lexer rules, where the dimensions define like utf-8 code. View in context: https://bugs.webkit.org/attachment.cgi?id=114637&action=review > LayoutTests/fast/css/parsing-css-number-types.html:13 > +#a { font-size: 16px; } > +#b { font-size: 16\70\78; } > +#c { font-size: 16\70x; } > +#d { font-size: 16p\78; } > +#e { font-size: 1em; } > +#f { font-size: 1\65m; } > +#g { font-size: 1\65\6D; } > +#h { font-size: 1\65\6d; } > +#i { font-size: 12pt } Please add some uppercase / lowercase test here. I.e: 12pT same as 12\70\54 Would be a good idea to add more number types (S, KhZ, gRaD). You can find them in tokenizer.flex grouped in one block (lines starting with {num}).
Szilard Ledan
Comment 5 2011-11-22 05:12:38 PST
Created attachment 116209 [details] Updated patch
Zoltan Herczeg
Comment 6 2011-12-08 06:35:00 PST
Darin, what do you think of this patch?
WebKit Review Bot
Comment 7 2011-12-08 10:53:26 PST
Comment on attachment 116209 [details] Updated patch Clearing flags on attachment: 116209 Committed r102350: <http://trac.webkit.org/changeset/102350>
WebKit Review Bot
Comment 8 2011-12-08 10:53:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.