| Summary: | A test for css parser number types problem. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Szilard Ledan <szledan> | ||||||
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | darin, webkit.review.bot, zherczeg | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 69083 | ||||||||
| Attachments: |
|
||||||||
|
Description
Szilard Ledan
2011-11-10 01:52:44 PST
Created attachment 114637 [details]
A test for CSS lexer rules, where the dimensions define like utf-8 code.
Please set r? to the patch. (In reply to comment #2) > Please set r? to the patch. Thanks! Comment on attachment 114637 [details] A test for CSS lexer rules, where the dimensions define like utf-8 code. View in context: https://bugs.webkit.org/attachment.cgi?id=114637&action=review > LayoutTests/fast/css/parsing-css-number-types.html:13 > +#a { font-size: 16px; } > +#b { font-size: 16\70\78; } > +#c { font-size: 16\70x; } > +#d { font-size: 16p\78; } > +#e { font-size: 1em; } > +#f { font-size: 1\65m; } > +#g { font-size: 1\65\6D; } > +#h { font-size: 1\65\6d; } > +#i { font-size: 12pt } Please add some uppercase / lowercase test here. I.e: 12pT same as 12\70\54 Would be a good idea to add more number types (S, KhZ, gRaD). You can find them in tokenizer.flex grouped in one block (lines starting with {num}). Created attachment 116209 [details]
Updated patch
Darin, what do you think of this patch? Comment on attachment 116209 [details] Updated patch Clearing flags on attachment: 116209 Committed r102350: <http://trac.webkit.org/changeset/102350> All reviewed patches have been landed. Closing bug. |