Summary: | Renovate ARMv7 assembler/macro-assembler | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | joepeck, ossy, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 137871 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Gavin Barraclough
2011-11-09 17:50:43 PST
Created attachment 114413 [details]
Fix
Attachment 114413 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Last 3072 characters of output:
e/JavaScriptCore/ChangeLog:20: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:21: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:22: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:23: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:24: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:25: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:26: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:27: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:28: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:29: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/assembler/ARMv7Assembler.h:1420: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/JavaScriptCore/assembler/ARMv7Assembler.h:1593: vcvt_signedToFloatingPoint is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMv7Assembler.h:1599: vcvt_floatingPointToSigned is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:245: shift_amount is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:260: shift_amount is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:317: shift_amount is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:332: shift_amount is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:342: shift_amount is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:357: shift_amount is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:835: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Total errors found: 29 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 114413 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=114413&action=review r=me > Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:332 > + void rshift32(RegisterID shift_amount, RegisterID dest) shift_amount => shiftAmount is The WebKit Style (TM). *** Bug 71730 has been marked as a duplicate of this bug. *** Re-opened since this is blocked by bug 137871 close again, because it was reopened acidentally/automatically by webkit-patch |