Bug 71969

Summary:

De-virtualize JSGlobalObject::allowsAccessFrom

Product:

WebKit

Reporter:

Mark Hahnenberg <mhahnenberg>

Component:

JavaScriptCore

Assignee:

Mark Hahnenberg <mhahnenberg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Mark Hahnenberg

Reported 2011-11-09 16:40:29 PST

There's only one call site of this function in WebScriptObject which we can safely cast to JSDOMWindowBase and call that version of the function, eliminating the need for this function to be virtual (or present in JSGlobalObject at all).

Attachments
Patch (3.91 KB, patch) 2011-11-09 17:08 PST, Mark Hahnenberg	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mark Hahnenberg

Comment 1 2011-11-09 17:08:52 PST

Created attachment 114399 [details] Patch

Mark Hahnenberg

Comment 2 2011-11-11 11:35:40 PST

Committed r99993: <http://trac.webkit.org/changeset/99993>

Note You need to log in before you can comment on or make changes to this bug.