Bug 71917

Summary: StyleSheet: Devirtualize is{CSS,XSL}StyleSheet().
Product: WebKit Reporter: Andreas Kling <kling>
Component: CSSAssignee: Andreas Kling <kling>
Status: RESOLVED WONTFIX    
Severity: Normal CC: macpherson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
kling: review-
Patch v2 kling: review-

Description Andreas Kling 2011-11-09 07:52:58 PST 
Let's put the subclass type in a bit instead. This will also let us assert that XSLStyleSheets aren't created with CSSRule parents.
Comment 1 Andreas Kling 2011-11-09 08:01:07 PST 
Created attachment 114281 [details]
Patch
Comment 2 Andreas Kling 2011-11-09 08:02:53 PST 
Comment on attachment 114281 [details]
Patch

Woops, didn't remove the virtuals from the subclasses!
Comment 3 Andreas Kling 2011-11-09 08:10:26 PST 
Created attachment 114283 [details]
Patch v2
Comment 4 Antti Koivisto 2011-11-09 08:17:03 PST 
Comment on attachment 114281 [details]
Patch

I don't think we should do this as there don't seem to be compelling performance or memory arguments for complete devirtualization here.