Bug 71911

Summary:

[Qt] Enable skipped but now passing tests (http/tests)

Product:

WebKit

Reporter:

Zoltan Arvai <zarvai>

Component:

Tools / Tests

Assignee:

Zoltan Arvai <zarvai>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jesus, ossy

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

72496

Bug Blocks:

Attachments:

Description	Flags
http-unskip	none

Zoltan Arvai

Reported 2011-11-09 07:16:53 PST

"run-webkit-tests --no-launch-safari --no-sample-on-timeout --no-new-test-results --results-directory layout-test-results --use-remote-links-to-tests --release --qt --force http/tests" is resulting a resonable amount of "Expected to fail, but passed" tests. This should be examined and passing tests should be unskipped. https://lists.webkit.org/pipermail/webkit-qt/2011-November/002078.html

Attachments
http-unskip (8.29 KB, patch) 2011-11-14 06:10 PST, Zoltan Arvai	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Zoltan Arvai

Comment 1 2011-11-14 06:10:37 PST

Created attachment 114930 [details] http-unskip Remove 28 tests from Skipped. Those tests passes with Qt 4.8.0-rc1 without side effects.

Csaba Osztrogonác

Comment 2 2011-11-14 06:14:04 PST

Comment on attachment 114930 [details] http-unskip View in context: https://bugs.webkit.org/attachment.cgi?id=114930&action=review > LayoutTests/platform/qt/Skipped:-2494 > -# [Qt] http/tests/notifications/icon-does-not-exist.html makes fast/notifications/notifications-click-event.html fail > -# https://bugs.webkit.org/show_bug.cgi?id=71693 > -http/tests/notifications/icon-does-not-exist.html > - We shouldn't remove this one, because it makes fast/notifications/notifications-click-event.html :)

Csaba Osztrogonác

Comment 3 2011-11-14 08:49:48 PST

Comment on attachment 114930 [details] http-unskip View in context: https://bugs.webkit.org/attachment.cgi?id=114930&action=review Otherwise LGTM, let's land it tomorrow after one more test. > LayoutTests/platform/qt/Skipped:-2178 > -# new test introduced in r88958, but fail on Qt > -# https://bugs.webkit.org/show_bug.cgi?id=62741 > -http/tests/appcache/video.html This test still fails for me. >> LayoutTests/platform/qt/Skipped:-2494 >> -# [Qt] http/tests/notifications/icon-does-not-exist.html makes fast/notifications/notifications-click-event.html fail >> -# https://bugs.webkit.org/show_bug.cgi?id=71693 >> -http/tests/notifications/icon-does-not-exist.html >> - > > We shouldn't remove this one, because it makes fast/notifications/notifications-click-event.html :) We shouldn't remove this one, because it makes fast/notifications/notifications-click-event.html :)

Csaba Osztrogonác

Comment 4 2011-11-15 06:43:28 PST

Comment on attachment 114930 [details] http-unskip View in context: https://bugs.webkit.org/attachment.cgi?id=114930&action=review Otherwise LGTM, let's land it tomorrow after one more test. > LayoutTests/platform/qt/Skipped:-566 > -# [Qt] http/tests/misc/link-rel-icon-beforeload.html is flakey > -# https://bugs.webkit.org/show_bug.cgi?id=63518 > -http/tests/misc/link-rel-icon-beforeload.html > - Still fails. >> LayoutTests/platform/qt/Skipped:-2178 >> -# new test introduced in r88958, but fail on Qt >> -# https://bugs.webkit.org/show_bug.cgi?id=62741 >> -http/tests/appcache/video.html > > This test still fails for me. This test still fails for me. >>> LayoutTests/platform/qt/Skipped:-2494 >>> -# [Qt] http/tests/notifications/icon-does-not-exist.html makes fast/notifications/notifications-click-event.html fail >>> -# https://bugs.webkit.org/show_bug.cgi?id=71693 >>> -http/tests/notifications/icon-does-not-exist.html >>> - >> >> We shouldn't remove this one, because it makes fast/notifications/notifications-click-event.html :) > > We shouldn't remove this one, because it makes fast/notifications/notifications-click-event.html :) We shouldn't remove this one, because it makes fast/notifications/notifications-click-event.html :)

Csaba Osztrogonác

Comment 5 2011-11-15 08:00:19 PST

Comment on attachment 114930 [details] http-unskip Fixed patch landed in http://trac.webkit.org/changeset/100281

Csaba Osztrogonác

Comment 6 2011-11-16 08:15:05 PST

Reopen, because it was rolled out by http://trac.webkit.org/changeset/100281. But it seems this patch is absolutely innocent. :) I'll reland it tomorrow.

Csaba Osztrogonác

Comment 7 2011-11-17 07:42:58 PST

Relanded in http://trac.webkit.org/changeset/100622

Note You need to log in before you can comment on or make changes to this bug.