Bug 71904

Summary:

CSS exclusions: parse the wrap-flow and wrap-through properties

Product:

WebKit

Reporter:

Alexandru Chiculita <achicu>

Component:

CSS

Assignee:

Mihnea Ovidenie <mihnea>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, macpherson, mihnea, simon.fraser, webkit-bug-importer, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

URL:

http://dev.w3.org/csswg/css3-exclusions/

Bug Depends on:

Bug Blocks:

57311

Attachments:

Description	Flags
Patch	webkit.review.bot: commit-queue-
Patch 2	webkit.review.bot: commit-queue-
Patch 3	none

Alexandru Chiculita

Reported 2011-11-09 06:44:48 PST

Add parsing code for wrap-flow and wrap-through properties. http://dev.w3.org/csswg/css3-exclusions/#wrap-flow-property http://dev.w3.org/csswg/css3-exclusions/#wrap-through-property

Attachments
Patch (26.20 KB, patch) 2011-11-14 07:00 PST, Mihnea Ovidenie	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Patch 2 (26.27 KB, patch) 2011-11-14 08:46 PST, Mihnea Ovidenie	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Patch 3 (29.82 KB, patch) 2011-11-15 01:28 PST, Mihnea Ovidenie	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2011-11-09 09:25:17 PST

<rdar://problem/10419702>

Mihnea Ovidenie

Comment 2 2011-11-14 07:00:02 PST

Created attachment 114940 [details] Patch

WebKit Review Bot

Comment 3 2011-11-14 07:21:59 PST

Comment on attachment 114940 [details] Patch Attachment 114940 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10472258

Mihnea Ovidenie

Comment 4 2011-11-14 08:46:42 PST

Created attachment 114954 [details] Patch 2 1. Use || instead of | in CSSParser.cpp 2. Rework wrap-through-parsing.js

WebKit Review Bot

Comment 5 2011-11-14 09:51:32 PST

Comment on attachment 114954 [details] Patch 2 Attachment 114954 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10473247 New failing tests: svg/css/getComputedStyle-basic.xhtml fast/css/getComputedStyle/computed-style.html fast/css/getComputedStyle/computed-style-without-renderer.html

Mihnea Ovidenie

Comment 6 2011-11-15 01:28:52 PST

Created attachment 115120 [details] Patch 3 Add expected results for chromium-win.

WebKit Review Bot

Comment 7 2011-11-17 00:08:49 PST

Comment on attachment 115120 [details] Patch 3 Clearing flags on attachment: 115120 Committed r100570: <http://trac.webkit.org/changeset/100570>

WebKit Review Bot

Comment 8 2011-11-17 00:08:54 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.