Bug 71861

Summary: Basic DFG definitions should be moved out of DFGNode.h
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 71744    
Attachments:
Description Flags
the patch none

Filip Pizlo
Reported 2011-11-08 15:01:44 PST
DFGNode.h nominally contains the Node class and things directly related to it. But right now it also happens to contain a bunch of #define's relating to the DFG's configuration, as well as some common types that the DFG uses everywhere (like BlockIndex and NodeIndex). These should be moved into a separate file, so that it is possible to refer to those types without having to pull in the definition of Node.
Attachments
the patch (10.32 KB, patch)
2011-11-08 15:04 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2011-11-08 15:04:32 PST
Created attachment 114161 [details] the patch Checking to see if this makes bots happy.
Filip Pizlo
Comment 2 2011-11-08 16:12:55 PST
Landed in http://trac.webkit.org/changeset/99627
Note You need to log in before you can comment on or make changes to this bug.