Bug 71842

Summary: Chromium: Add plumbing to enable dragging dev tools via the empty space on the toolbar.
Product: WebKit Reporter: asvitkine
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: fishd, pfeldman, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+, pfeldman: commit-queue+

asvitkine
Reported 2011-11-08 11:42:59 PST
Chromium: Add plumbing to enable dragging dev tools via the empty space on the toolbar.
Attachments
Patch (2.10 KB, patch)
2011-11-08 11:44 PST, asvitkine 		no flags
DetailsFormatted DiffDiff
Patch (2.46 KB, patch)
2011-11-09 06:51 PST, asvitkine 		pfeldman: review+
pfeldman: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
asvitkine
Comment 1 2011-11-08 11:44:34 PST
Created attachment 114125 [details] Patch
WebKit Review Bot
Comment 2 2011-11-08 11:47:54 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Darin Fisher (:fishd, Google)
Comment 3 2011-11-08 13:21:38 PST
Comment on attachment 114125 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114125&action=review > Source/WebKit/chromium/public/WebDevToolsFrontendClient.h:52 > + virtual void moveWindowBy(float x, float y) { } nit: had you considered using WebFloatPoint?
asvitkine
Comment 4 2011-11-09 06:51:16 PST
Created attachment 114265 [details] Patch
asvitkine
Comment 5 2011-11-09 06:51:45 PST
As suggested by Darin, here's a version of the patch that uses WebFloatPoint.
asvitkine
Comment 6 2011-11-09 07:22:35 PST
Can I get a commit-queue+?
Pavel Feldman
Comment 7 2011-11-09 07:30:54 PST
Committed r99714: <http://trac.webkit.org/changeset/99714>
Note You need to log in before you can comment on or make changes to this bug.