Bug 71787

Summary: DFG OSR exit code should be generated by a separate compiler, not related to DFG::JITCompiler
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: yuqiang.xian
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 71744    
Attachments:
Description Flags
work in progress
none
work in progress
none
work in progress
webkit-ews: commit-queue-
the patch
barraclough: review-
the patch barraclough: review+

Filip Pizlo
Reported 2011-11-08 02:38:02 PST
patch forthcoming
Attachments
work in progress (59.95 KB, patch)
2011-11-08 02:40 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
work in progress (125.35 KB, patch)
2011-11-08 03:12 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
work in progress (125.11 KB, patch)
2011-11-08 03:20 PST, Filip Pizlo 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
the patch (127.56 KB, patch)
2011-11-08 14:01 PST, Filip Pizlo 		barraclough: review-
DetailsFormatted DiffDiff
the patch (126.77 KB, patch)
2011-11-08 14:15 PST, Filip Pizlo 		barraclough: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2011-11-08 02:40:00 PST
Created attachment 114020 [details] work in progress Still need to do this for 32_64.
Filip Pizlo
Comment 2 2011-11-08 03:12:03 PST
Created attachment 114026 [details] work in progress This is not the real patch; I want to see what happens on the bots.
Filip Pizlo
Comment 3 2011-11-08 03:20:53 PST
Created attachment 114029 [details] work in progress Did some merging.
Early Warning System Bot
Comment 4 2011-11-08 03:40:14 PST
Comment on attachment 114029 [details] work in progress Attachment 114029 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10374047
Gyuyoung Kim
Comment 5 2011-11-08 03:58:20 PST
Comment on attachment 114029 [details] work in progress Attachment 114029 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10369063
Filip Pizlo
Comment 6 2011-11-08 14:01:20 PST
Created attachment 114150 [details] the patch
Gavin Barraclough
Comment 7 2011-11-08 14:05:47 PST
Comment on attachment 114150 [details] the patch Please update per http://trac.webkit.org/changeset/99614 (basically replace the calls to jitcode start() with calls to the new executableAddressAtOffset to get a THUMB2 safe address).
Filip Pizlo
Comment 8 2011-11-08 14:15:12 PST
Created attachment 114151 [details] the patch Merged with http://trac.webkit.org/changeset/99614
Filip Pizlo
Comment 9 2011-11-08 16:21:29 PST
Landed in http://trac.webkit.org/changeset/99629
Yuqiang Xian
Comment 10 2011-11-08 16:52:27 PST
I guess the Gtk make list should by updated accordingly, i.e. Source/JavaScriptCore/GNUmakefile.list.am
Filip Pizlo
Comment 11 2011-11-08 17:01:45 PST
(In reply to comment #10) > I guess the Gtk make list should by updated accordingly, i.e. Source/JavaScriptCore/GNUmakefile.list.am Oops! Fixed in http://trac.webkit.org/changeset/99637
Note You need to log in before you can comment on or make changes to this bug.