Bug 71773

Summary: Web Inspector: refactor shortcuts and settings screens
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch pfeldman: review+

Yury Semikhatsky
Reported 2011-11-07 23:42:53 PST
The way we show and hide shortcuts and settings screens makes it hard adding other HelpScreen descendants to the code as we would have to manually hide all possible screens. Instead we should keep a pointer to the visible instance and hide it automatically when new screen is about to be displayed.
Attachments
Patch (6.10 KB, patch)
2011-11-07 23:44 PST, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2011-11-07 23:44:57 PST
Created attachment 114001 [details] Patch
Yury Semikhatsky
Comment 2 2011-11-08 00:56:24 PST
Committed r99533: <http://trac.webkit.org/changeset/99533>
Note You need to log in before you can comment on or make changes to this bug.