Summary: | WTF should have an Xcode project | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Rowe (bdash) <mrowe> | ||||
Component: | Web Template Framework | Assignee: | Mark Rowe (bdash) <mrowe> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, eric, mrowe | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 75673 | ||||||
Attachments: |
|
Description
Mark Rowe (bdash)
2011-11-07 17:13:46 PST
Created attachment 113963 [details] Patch v1 This adds an Xcode project that includes only Stub.cpp and Stub.h. They’re built in to a library at the appropriate path for each configuration (WebKitBuild/{Debug,Release}/libWTF.a and /usr/local/lib/libWTF.a) and headers are installed in to the appropriate location (WebKitBuild/{Debug,Release}/usr/local/include/wtf and /usr/local/include/wtf). I tested building WTF in this project and everything appears to build except for DateMath.cpp (due to bug 71747). I have not yet done any work on making JavaScriptCore and other projects use the built products of this new project. Comment on attachment 113963 [details] Patch v1 Now that bug 71747 is fixed, we should probably land this patch. I'll add a ChangeLog. Thanks Mark! Committed r100850: <http://trac.webkit.org/changeset/100850> It’s not clear to me why you landed my patch without first consulting with me. It wasn’t even marked for review! The patch was intentionally not flagged for review because I have not yet tested whether the built product is suitable for use by other projects. If I had wanted it to be reviewed I’d have set the review flag to ?, and if I had wanted it landed the commit-queue flag would also have been set. Oh, I'm sorry. I misunderstood. I thought we just needed to resolve bug 71747. Given that the WTF folder isn't referenced by anything else yet, I don't see any harm in having landed it. Maybe it would make sense to iterate on the xcodeproj now that it's landed? |