Bug 71749

Summary: IndexedDB: reference cycle between IDBDatabase and IDBTransaction
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: New BugsAssignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: dgrogan, hans, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Joshua Bell
Reported 2011-11-07 16:32:17 PST
IndexedDB: reference cycle between IDBDatabase and IDBTransaction
Attachments
Patch (6.04 KB, patch)
2011-11-07 16:33 PST, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch (9.89 KB, patch)
2011-11-07 17:06 PST, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch (10.45 KB, patch)
2011-11-08 10:46 PST, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2011-11-07 16:33:16 PST
Created attachment 113953 [details] Patch
Joshua Bell
Comment 2 2011-11-07 16:36:34 PST
Comment on attachment 113953 [details] Patch Layout test pending.
Joshua Bell
Comment 3 2011-11-07 17:06:00 PST
Created attachment 113962 [details] Patch
Joshua Bell
Comment 4 2011-11-07 17:08:22 PST
Prior to this patch, if you called IDBDatabase.createObjectStore() following a VERSION_CHANGE transaction with an object store name that already existed the call would make it to the back-end before failing, and fail with CONSTRAINT_ERR rather than the expected NOT_ALLOWED_ERR. The updated layout test verifies that the transaction check is now happening on the front-end.
David Grogan
Comment 5 2011-11-07 17:20:01 PST
LGTM
Joshua Bell
Comment 6 2011-11-08 10:46:49 PST
Created attachment 114115 [details] Patch
Joshua Bell
Comment 7 2011-11-08 10:48:50 PST
Updated the layout test to clarify the new test case based on verbal feedback from dgrogan@. Also fixed the existing tests to actually try removing the object stores as claimed. tony@ - can you take a look?
WebKit Review Bot
Comment 8 2011-11-08 11:41:57 PST
Comment on attachment 114115 [details] Patch Clearing flags on attachment: 114115 Committed r99599: <http://trac.webkit.org/changeset/99599>
WebKit Review Bot
Comment 9 2011-11-08 11:42:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.