Bug 71722

Summary:

Uninitialized Heap member var

Product:

WebKit

Reporter:

Andrew Wason <rectalogic>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

fpizlo, kling, oliver, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
initialize m_blockFreeingThreadShouldQuit	none

Andrew Wason

Reported 2011-11-07 12:45:20 PST

m_blockFreeingThreadShouldQuit is uninitialized in Source/JavaScriptCore/heap/Heap.cpp valgrind complains: ==24728== Thread 3: ==24728== Conditional jump or move depends on uninitialised value(s) ==24728== at 0x6923EF7: JSC::Heap::blockFreeingThreadMain() (Heap.cpp:411) ==24728== by 0x6923D7B: JSC::Heap::blockFreeingThreadStartFunc(void*) (Heap.cpp:405) ==24728== by 0x68FF7BC: WTF::threadEntryPoint(void*) (Threading.cpp:67) ==24728== by 0x68F8618: WTF::ThreadPrivate::run() (ThreadingQt.cpp:67) ==24728== by 0x91C3FF4: QThreadPrivate::start(void*) (qthread_unix.cpp:331) ==24728== by 0x96A19C9: start_thread (pthread_create.c:300) ==24728== by 0xA14C70C: clone (clone.S:112) ==24728== ==24728== Conditional jump or move depends on uninitialised value(s) ==24728== at 0x6923CBE: JSC::Heap::waitForRelativeTimeWhileHoldingLock(double) (Heap.cpp:388) ==24728== by 0x6923D2E: JSC::Heap::waitForRelativeTime(double) (Heap.cpp:400) ==24728== by 0x6923DAB: JSC::Heap::blockFreeingThreadMain() (Heap.cpp:414) ==24728== by 0x6923D7B: JSC::Heap::blockFreeingThreadStartFunc(void*) (Heap.cpp:405) ==24728== by 0x68FF7BC: WTF::threadEntryPoint(void*) (Threading.cpp:67) ==24728== by 0x68F8618: WTF::ThreadPrivate::run() (ThreadingQt.cpp:67) ==24728== by 0x91C3FF4: QThreadPrivate::start(void*) (qthread_unix.cpp:331) ==24728== by 0x96A19C9: start_thread (pthread_create.c:300) ==24728== by 0xA14C70C: clone (clone.S:112) ==24728== ==24728== Conditional jump or move depends on uninitialised value(s) ==24728== at 0x6923DB9: JSC::Heap::blockFreeingThreadMain() (Heap.cpp:415) ==24728== by 0x6923D7B: JSC::Heap::blockFreeingThreadStartFunc(void*) (Heap.cpp:405) ==24728== by 0x68FF7BC: WTF::threadEntryPoint(void*) (Threading.cpp:67) ==24728== by 0x68F8618: WTF::ThreadPrivate::run() (ThreadingQt.cpp:67) ==24728== by 0x91C3FF4: QThreadPrivate::start(void*) (qthread_unix.cpp:331) ==24728== by 0x96A19C9: start_thread (pthread_create.c:300) ==24728== by 0xA14C70C: clone (clone.S:112)

Attachments
initialize m_blockFreeingThreadShouldQuit (1.09 KB, patch) 2011-11-07 12:56 PST, Andrew Wason	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andrew Wason

Comment 1 2011-11-07 12:56:10 PST

Created attachment 113915 [details] initialize m_blockFreeingThreadShouldQuit

Filip Pizlo

Comment 2 2011-11-07 13:21:19 PST

Comment on attachment 113915 [details] initialize m_blockFreeingThreadShouldQuit Ooops! It's a wonder that this code has "worked" for so long. Thanks for the fix! r=me

Oliver Hunt

Comment 3 2011-11-07 13:26:51 PST

<rdar://problem/10407863>

WebKit Review Bot

Comment 4 2011-11-07 14:20:34 PST

Comment on attachment 113915 [details] initialize m_blockFreeingThreadShouldQuit Clearing flags on attachment: 113915 Committed r99477: <http://trac.webkit.org/changeset/99477>

WebKit Review Bot

Comment 5 2011-11-07 14:20:39 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.