Bug 71667

Summary:

CSSValue: Devirtualize cssValueType().

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

CSS

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

macpherson, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

71666, 71668

Attachments:

Description	Flags
Patch	koivisto: review+

Description Andreas Kling 2011-11-07 04:44:46 PST

CSSValue: Devirtualize cssValueType().

Comment 1 Andreas Kling 2011-11-07 04:49:52 PST

Created attachment 113845 [details]
Patch

Comment 2 Antti Koivisto 2011-11-07 05:10:57 PST

Comment on attachment 113845 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113845&action=review

r=me

> Source/WebCore/css/CSSValue.h:90
> +private:
> +    unsigned m_type : 3; // Type

Maybe a FIXME here indicating that the memory regression will fix itself soonish.

Comment 3 Antti Koivisto 2011-11-07 05:25:44 PST

Comment on attachment 113845 [details]
Patch

Also it would be nice if CSSPrimitiveValue had only one field called m_type...

Comment 4 Andreas Kling 2011-11-07 05:34:38 PST

Committed r99409: <http://trac.webkit.org/changeset/99409>