Bug 71655 – [GTK] fast/frames/flattening/frameset-flattening-simple.html is flaky

• Component: WebKitGTK
• Status: RESOLVED CONFIGURATION CHANGED

[Philippe Normand]

Attaching simple patch.

[Philippe Normand]

Created attachment 113833 [details]
proposed patch

[Philippe Normand]

Committed r99433: <http://trac.webkit.org/changeset/99433>

[Philippe Normand]

It's still flaky :(


--- /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/fast/frames/flattening/frameset-flattening-simple-expected.txt 
+++ /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/fast/frames/flattening/frameset-flattening-simple-actual.txt 
@@ -1,14 +1,14 @@
-layer at (0,0) size 1000x600
-  RenderView at (0,0) size 800x584
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderFrameSet {FRAMESET} at (0,0) size 1000x600
-      RenderFrame {FRAME} at (0,0) size 800x600
-        layer at (0,0) size 800x600
-          RenderView at (0,0) size 800x600
-        layer at (0,0) size 800x600
-          RenderBlock {HTML} at (0,0) size 800x600
-            RenderBody {BODY} at (8,8) size 784x576 [bgcolor=#008000]
+layer at (0,0) size 1000x584
+  RenderView at (0,0) size 784x584
+layer at (0,0) size 784x584
+  RenderBlock {HTML} at (0,0) size 784x584
+    RenderFrameSet {FRAMESET} at (0,0) size 1000x584
+      RenderFrame {FRAME} at (0,0) size 800x584
+        layer at (0,0) size 800x584
+          RenderView at (0,0) size 800x584
+        layer at (0,0) size 800x584
+          RenderBlock {HTML} at (0,0) size 800x584
+            RenderBody {BODY} at (8,8) size 784x560 [bgcolor=#008000]
               RenderBlock {P} at (0,0) size 784x19
                 RenderText {#text} at (0,0) size 445x19
                   text run at (0,0) width 445: "Test for frameset flattening. The flattening only works inside the DRT."
@@ -17,9 +17,9 @@
                   text run at (0,0) width 458: "This frame should be 800px wide and not be scrollable (have scrollbars)."
         layer at (0,100) size 800x1
           RenderBlock (positioned) {DIV} at (0,100) size 800x1
-      RenderFrame {FRAME} at (800,0) size 200x600
-        layer at (0,0) size 200x600
-          RenderView at (0,0) size 200x600
-        layer at (0,0) size 200x600
-          RenderBlock {HTML} at (0,0) size 200x600
-            RenderBody {BODY} at (8,8) size 184x584
+      RenderFrame {FRAME} at (800,0) size 200x584
+        layer at (0,0) size 200x584
+          RenderView at (0,0) size 200x584
+        layer at (0,0) size 200x584
+          RenderBlock {HTML} at (0,0) size 200x584
+            RenderBody {BODY} at (8,8) size 184x568

[Philippe Normand]

Marked flaky in http://trac.webkit.org/changeset/100279

[Frédéric Wang (:fredw)]

(In reply to Philippe Normand from comment #3)
> It's still flaky :(
> 
> 
> ---
> /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/fast/
> frames/flattening/frameset-flattening-simple-expected.txt 
> +++
> /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/fast/
> frames/flattening/frameset-flattening-simple-actual.txt 
> -      RenderFrame {FRAME} at (0,0) size 800x600
> +      RenderFrame {FRAME} at (0,0) size 800x584

It seems that the width is always 800px but the height changes, probably because of scrollbars on the main frame. I'm trying to rewrite the test in bug 183129, that would allow to get rid of these scrollbars.

[Michael Catanzaro]

Does GTK support frame flattening...?

[Frédéric Wang (:fredw)]

(In reply to Michael Catanzaro from comment #6)
> Does GTK support frame flattening...?

Yes, it does.

[Frédéric Wang (:fredw)]

It seems frameset-flattening-simple is no longer flacky on GTK release but there are other similar tests (e.g. from bug 80129 marked as duplicate) that I did not rewrite and are still flacky. Also I wonder why frameset-flattening-simple is failing on debug build only: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&showFlaky=true&tests=frameset-flattening

[Ahmad Saleem]

Test is gone - https://github.com/WebKit/WebKit/commit/37224f042c178a094cc2287dee595345bc89f687