Bug 71647

Summary: DFG operationCreateThis slow path may get the wrong callee in case of inlining
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch oliver: review+

Filip Pizlo
Reported 2011-11-06 19:43:47 PST
This bug is self-evident in the code, but it's really hard to reproduce - I only saw it when working on a changeset that had bugs in value profiling. Patch forthcoming.
Attachments
the patch (6.88 KB, patch)
2011-11-06 19:45 PST, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2011-11-06 19:45:54 PST
Created attachment 113820 [details] the patch
WebKit Review Bot
Comment 2 2011-11-06 19:51:16 PST
Attachment 113820 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGOperations.h:67: DFG_OPERATION is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 3 2011-11-06 22:19:51 PST
Comment on attachment 113820 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=113820&action=review >> Source/JavaScriptCore/dfg/DFGOperations.h:67 >> +typedef JSCell* DFG_OPERATION (*C_DFGOperation_ECC)(ExecState*, JSCell*, JSCell*); > > DFG_OPERATION is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] We really should beat the stylebot into not producing these warnings
Oliver Hunt
Comment 4 2011-11-07 11:16:02 PST
<rdar://problem/10406876>
Filip Pizlo
Comment 5 2011-11-07 16:37:56 PST
Landed in http://trac.webkit.org/changeset/99502
Note You need to log in before you can comment on or make changes to this bug.