Bug 71646

Summary: Remove unnecessary use of function pointer in FrameSelection::modify()
Product: WebKit Reporter: Alice Boxhall <aboxhall>
Component: New BugsAssignee: Alice Boxhall <aboxhall>
Severity: Normal CC: rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Alice Boxhall 2011-11-06 19:09:28 PST
Remove unnecessary use of function pointer in FrameSelection::modify()
Comment 1 Alice Boxhall 2011-11-06 19:10:45 PST
Created attachment 113818 [details]
Comment 2 Ryosuke Niwa 2011-11-06 19:41:33 PST
Comment on attachment 113818 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=113818&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

Please remove this line before commit.
Comment 3 Alice Boxhall 2011-11-07 14:24:30 PST
Created attachment 113930 [details]
Comment 4 WebKit Review Bot 2011-11-07 14:25:54 PST
Comment on attachment 113930 [details]

Rejecting attachment 113930 [details] from review queue.

aboxhall@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 5 WebKit Review Bot 2011-11-07 15:43:37 PST
Comment on attachment 113930 [details]

Clearing flags on attachment: 113930

Committed r99492: <http://trac.webkit.org/changeset/99492>
Comment 6 WebKit Review Bot 2011-11-07 15:43:42 PST
All reviewed patches have been landed.  Closing bug.