| Summary: | Revert platform and scrolling to ints | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||||||
| Component: | Platform | Assignee: | Emil A Eklund <eae> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | darin, dglazkov, eric, leviw, tkent, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 63567 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Emil A Eklund
2011-11-04 13:40:16 PDT
Created attachment 113719 [details]
Patch
Comment on attachment 113719 [details]
Patch
OK.
Comment on attachment 113719 [details] Patch Attachment 113719 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10337137 Created attachment 113956 [details]
Patch for landing
Comment on attachment 113956 [details] Patch for landing Rejecting attachment 113956 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: n/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/10331863 Comment on attachment 113956 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=113956&action=review > Source/WebKit/chromium/ChangeLog:3 > + Need a short description and bug URL (OOPS!) The following ChangeLog files contain OOPS: trunk/Source/WebKit/chromium/ChangeLog Please don't ever say "OOPS" in a ChangeLog file. Ah, missed one. Thanks for pointing it out Adam. Created attachment 113966 [details]
Patch for landing
Comment on attachment 113966 [details] Patch for landing Clearing flags on attachment: 113966 Committed r99511: <http://trac.webkit.org/changeset/99511> All reviewed patches have been landed. Closing bug. |