Bug 71585

Summary:

Revert platform and scrolling to ints

Product:

WebKit

Reporter:

Emil A Eklund <eae>

Component:

Platform

Assignee:

Emil A Eklund <eae>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, dglazkov, eric, leviw, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

63567

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none

Emil A Eklund

Reported 2011-11-04 13:40:16 PDT

We are currently incorrectly using LayoutUnits and related types in a couple of places in the platform and scrolling code. These should be reverted back to ints.

Attachments
Patch (76.74 KB, patch) 2011-11-04 15:33 PDT, Emil A Eklund	no flags	Details Formatted Diff Diff
Patch for landing (78.07 KB, patch) 2011-11-07 16:37 PST, Emil A Eklund	no flags	Details Formatted Diff Diff
Patch for landing (78.29 KB, patch) 2011-11-07 17:31 PST, Emil A Eklund	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Emil A Eklund

Comment 1 2011-11-04 15:33:13 PDT

Created attachment 113719 [details] Patch

Eric Seidel (no email)

Comment 2 2011-11-04 15:44:53 PDT

Comment on attachment 113719 [details] Patch OK.

WebKit Review Bot

Comment 3 2011-11-04 15:55:23 PDT

Comment on attachment 113719 [details] Patch Attachment 113719 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10337137

Emil A Eklund

Comment 4 2011-11-07 16:37:05 PST

Created attachment 113956 [details] Patch for landing

WebKit Review Bot

Comment 5 2011-11-07 17:14:46 PST

Comment on attachment 113956 [details] Patch for landing Rejecting attachment 113956 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: n/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/10331863

Adam Barth

Comment 6 2011-11-07 17:17:39 PST

Comment on attachment 113956 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=113956&action=review > Source/WebKit/chromium/ChangeLog:3 > + Need a short description and bug URL (OOPS!) The following ChangeLog files contain OOPS: trunk/Source/WebKit/chromium/ChangeLog Please don't ever say "OOPS" in a ChangeLog file.

Emil A Eklund

Comment 7 2011-11-07 17:23:49 PST

Ah, missed one. Thanks for pointing it out Adam.

Emil A Eklund

Comment 8 2011-11-07 17:31:06 PST

Created attachment 113966 [details] Patch for landing

WebKit Review Bot

Comment 9 2011-11-07 18:11:23 PST

Comment on attachment 113966 [details] Patch for landing Clearing flags on attachment: 113966 Committed r99511: <http://trac.webkit.org/changeset/99511>

WebKit Review Bot

Comment 10 2011-11-07 18:11:28 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.