Bug 71553

Summary:

[EFL] Need to replace api's object parameter with proper name.

Product:

WebKit

Reporter:

KwangHyuk <hyuki.kim>

Component:

WebKit EFL

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, rakuco, ryuan.choi, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Linux

Attachments:

Description	Flags
Patch	none

KwangHyuk

Reported 2011-11-04 04:41:29 PDT

Some parameter's name on ewk doesn't seem well defined enough. For example, > static void _ewk_view_tiled_smart_add(Evas_Object* ewkTile) > Ewk_Tile_Unused_Cache* ewk_view_tiled_unused_cache_get(const Evas_Object* ewkTile) ewkTile must be repalced with ewkView. > void ewk_tiled_backing_store_updates_process(Evas_Object* ewkTile) > Eina_Bool ewk_tiled_backing_store_update(Evas_Object* ewkTile, const Eina_Rectangle* update) ewkTile must be replaced with backingStore. Gyuyoung or I will fix them if there is no objection.

Attachments
Patch (32.26 KB, patch) 2011-11-06 17:35 PST, Gyuyoung Kim	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Raphael Kubo da Costa (:rakuco)

Comment 1 2011-11-04 06:28:47 PDT

(In reply to comment #0) > Some parameter's name on ewk doesn't seem well defined enough. > > For example, > > > static void _ewk_view_tiled_smart_add(Evas_Object* ewkTile) > > Ewk_Tile_Unused_Cache* ewk_view_tiled_unused_cache_get(const Evas_Object* ewkTile) > ewkTile must be repalced with ewkView. These are only examples and you're going to replace it in other functions such as ewk_view_tiled_unused_cache_set as well, right? How about the ewk_view_single functions? > > void ewk_tiled_backing_store_updates_process(Evas_Object* ewkTile) > > Eina_Bool ewk_tiled_backing_store_update(Evas_Object* ewkTile, const Eina_Rectangle* update) > ewkTile must be replaced with backingStore. OK.

Gyuyoung Kim

Comment 2 2011-11-06 17:35:10 PST

Created attachment 113814 [details] Patch

Gyuyoung Kim

Comment 3 2011-11-06 17:37:21 PST

I fix wrong parameter names with proper's name. - ewkTile -> ewkView in ewk_view_tiled.cpp - ewkSingle -> ewkView in ewk_view_single.cpp - ewkTile -> ewkBackingStore in ewk_tiled_backing_store.cpp - Change w, h, ctxt with width, height, context. - and so on.

KwangHyuk

Comment 4 2011-11-06 17:41:27 PST

LGTM.

Filip Pizlo

Comment 5 2011-11-07 19:33:23 PST

Comment on attachment 113814 [details] Patch r=me

WebKit Review Bot

Comment 6 2011-11-07 20:44:24 PST

Comment on attachment 113814 [details] Patch Clearing flags on attachment: 113814 Committed r99518: <http://trac.webkit.org/changeset/99518>

WebKit Review Bot

Comment 7 2011-11-07 20:44:29 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.