Bug 71549

Summary: new-run-webkit-tests autoinstalls python-irclib even though it doesn't need to
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch abarth: review+, abarth: commit-queue+

Eric Seidel (no email)
Reported 2011-11-04 02:22:50 PDT
new-run-webkit-tests autoinstalls python-irclib even though it doesn't need to Per: https://bugs.webkit.org/show_bug.cgi?id=71494#c7 This is a regression from instantiating a Host() object in new-run-webkit-tests. The best fix is probably to split IRC off of the core Host object.
Attachments
Patch (11.57 KB, patch)
2011-11-04 14:28 PDT, Eric Seidel (no email) 		abarth: review+
abarth: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-11-04 14:28:01 PDT
Created attachment 113715 [details] Patch
Adam Barth
Comment 2 2011-11-04 14:30:00 PDT
Comment on attachment 113715 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113715&action=review > Tools/Scripts/webkitpy/tool/main.py:65 > + def port(self): Can we rename this to deprecated_port() ? Probably best in a follow-up patch.
Eric Seidel (no email)
Comment 3 2011-11-04 15:09:15 PDT
Committed r99326: <http://trac.webkit.org/changeset/99326>
Note You need to log in before you can comment on or make changes to this bug.